| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_basebackups and slots |
| Date: | 2017-01-16 13:00:01 |
| Message-ID: | CABUevExPJPrgKjZos0xwdsV+BmWUscPU=HqPEkxLFXy_gn8nbA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 4, 2017 at 3:32 PM, Peter Eisentraut <
peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> This patch looks reasonable to me.
>
> Attached is a top-up patch with a few small fixups.
>
> I suggest to wait for the resolution of the "Replication/backup
> defaults" thread. I would not want to be in a situation where users who
> have not been trained to use replication slots now have yet another
> restart-only parameter to set before they can take a backup.
>
>
Thanks for the review and the top-up patch. I've applied it and pushed.
I just realized I missed crediting you with the review and the top-up in
the commit message. My apologies for this.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2017-01-16 15:17:46 | Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling) |
| Previous Message | Michael Paquier | 2017-01-16 12:46:46 | Re: Support for pg_receivexlog --format=plain|tar |