| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Mark Dilger <markdilger(at)yahoo(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, deepak <deepak(dot)pn(at)gmail(dot)com>, Alban Hertroys <haramrae(at)gmail(dot)com>, "pgsql-general(at)postgresql(dot)org" <pgsql-general(at)postgresql(dot)org> |
| Subject: | Re: FATAL: lock file "postmaster.pid" already exists |
| Date: | 2012-05-24 11:00:39 |
| Message-ID: | CABUevExK+ZkHQtenEPDQgMSAwH4f0JsbAjg4fXEW66=_nvm1CQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general |
On Thu, May 24, 2012 at 2:42 AM, Mark Dilger <markdilger(at)yahoo(dot)com> wrote:
> FindFirstFile can take a wildcard filename
> pattern. It appears that we are effectively
> calling FindFirstFile without a pattern, getting
> all 56000 file names with complete stat
> information, doing a poor-man's regex on
> those names, and matching just the temporary
> files.
>
> If RemovePgTempFiles were modified to
> pass a filter, this code might perform better
> on Windows. I'll look into this.
It might in that case be worthwhile looking at using scandir() on
platforms that support that as well, so that other platforms can
benefit from an optimization as well. Though I'm not sure how much
that would actually help - ISTM that one actually scans the whole
directory anyway, just you don't have to do it yourself...
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2012-05-24 13:33:38 | enhanced linestyles for psql |
| Previous Message | Magnus Hagander | 2012-05-24 10:58:18 | Re: FATAL: lock file "postmaster.pid" already exists |