Re: Moderation notices for comments not sent?

On Thu, Jan 14, 2021 at 9:07 PM Stephen Frost <sfrost(at)snowman(dot)net> wrote:
>
> Greetings,
>
> * Magnus Hagander (magnus(at)hagander(dot)net) wrote:
> > On Tue, Jan 5, 2021 at 6:58 PM Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> > > I've not figured out exactly what's going on, but moderation comments
> > > don't seem to be going to the NOTIFICATION_EMAIL address anymore for
> > > News articles (even though they used to). Seems to have stopped around
> > > September. Would be great if someone has time to look into this and
> > > figure out what happened, not sure when/if I will. Specifically, this
> > > is the email that's supposed to be generated under the 'if what' block
> > > of _send_moderation_message(). I suspect the issue is that it's just
> > > doing 'admmsg = message' instead of considering that there might be a
> > > value in 'notice'... For some reason django isn't crashing either
> > > though..
> >
> > Are you saying that it's not sending it when there is *just* a
> > comment, or also when some state is changed? I'm seeing moderation
> > comments delivered here, when I look in my mailbox, but just sending
> > notices without changing the state is not something that happens
> > often...
>
> Not sending when it's *just* a comment, that's correct.

Thanks! Identified, and fix pushed.

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/