| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Célestin Matte <celestin(dot)matte(at)cmatte(dot)me> |
| Cc: | PostgreSQL WWW <pgsql-www(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fix "push changes" crash in CommunityAuthSiteAdminForm |
| Date: | 2021-09-09 11:42:09 |
| Message-ID: | CABUevEx1Ye8jWYkuOqaao+aPX4oGAsuk4thFJx_Hd4LxoP1PyQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-www |
On Thu, Sep 9, 2021 at 12:09 PM Célestin Matte <celestin(dot)matte(at)cmatte(dot)me> wrote:
>
> Hello,
>
> I'm in the process of writing an Ansible script to install pglister, and for this, I'm using pgweb's auth system.
> I've encountered a crash in the web form to add a community auth site on the "push changes" option (on pgweb). This patch fixes it.
Hi!
Thanks! the fix looks good in general -- but how did you actually hit
the bug? I've been trying to reproduce it to verify the test, but I
can't figure out how... In all my tests, d['apiurl'] ends up being ''
(and actually existing), which makes it not a problem.
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Célestin Matte | 2021-09-09 12:53:49 | Re: [PATCH] Fix "push changes" crash in CommunityAuthSiteAdminForm |
| Previous Message | Célestin Matte | 2021-09-09 09:41:31 | [PATCH] Fix "push changes" crash in CommunityAuthSiteAdminForm |