From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Duplicate 'use' for TestLib in 001_ssltests.pl |
Date: | 2016-01-08 07:54:19 |
Message-ID: | CABUevEx0tE0=6=m5uAmgS2dmS2dpn8Z0qknPv90DDY6wN03nKg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jan 8, 2016 at 8:37 AM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
wrote:
> On Fri, Jan 8, 2016 at 4:16 PM, Kyotaro HORIGUCHI
> <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> > Hello, I noticed that 001_ssltests.pl uselessly (perhaps) imports
> > TestLib twice. Is this intentional? The following change made no
> > differences.
> >
> >
> > diff --git a/src/test/ssl/t/001_ssltests.pl b/src/test/ssl/t/
> 001_ssltests.pl
> > index 9ce0cf3..cd38e45 100644
> > --- a/src/test/ssl/t/001_ssltests.pl
> > +++ b/src/test/ssl/t/001_ssltests.pl
> > @@ -2,7 +2,6 @@ use strict;
> > use warnings;
> > use PostgresNode;
> > use TestLib;
> > -use TestLib;
> > use Test::More tests => 38;
> > use ServerSetup;
> > use File::Copy;
>
> Nice catch. Yes that's an oversight and should be removed.
>
Applied, thanks.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2016-01-08 07:57:15 | Re: Comment typo in port/atomics/arch-x86.h |
Previous Message | Michael Paquier | 2016-01-08 07:37:06 | Re: Duplicate 'use' for TestLib in 001_ssltests.pl |