From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, Tomas Vondra <tv(at)fuzzy(dot)cz>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_stat directory and pg_stat_statements |
Date: | 2014-06-03 09:38:24 |
Message-ID: | CABUevEwyooQVJquMxzXjhTiyhQ6M1B4rxYSxfpbDNYXiQzYzUQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Jun 2, 2014 at 4:07 PM, Andres Freund <andres(at)2ndquadrant(dot)com>
wrote:
> On 2014-06-02 22:59:55 +0900, Fujii Masao wrote:
> > On Thu, May 29, 2014 at 3:02 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> > > On Wed, May 28, 2014 at 10:49 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
> wrote:
> > >> You're concerned about the scenario using pg_upgrade? I'm not sure
> the detail
> > >> of pg_upgrade. But if it doesn't work properly, we should have gotten
> > >> the trouble
> > >
> > > I'm not worried about pg_upgrade, because by design pg_stat_statements
> > > will discard stats files that originated in earlier versions. However,
> > > I don't see a need to change pg_stat_statements to serialize its
> > > statistics to disk in the pg_stat directory before we branch off 9.4.
> > > As you mentioned, it's harmless.
> >
> > Yeah, that's an idea. OTOH, there is no *strong* reason to postpone
> > the fix to 9.5. So I just feel inclined to apply the fix now...
>
> +1 for fixing it now.
>
>
+1 for fixing it for 9.4 before the next beta, but *not* backpatching it to
9.3 - it *is* a behaviour change after all..
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2014-06-03 09:51:39 | Re: [BUGS] BUG #9652: inet types don't support min/max |
Previous Message | Soroosh Sardari | 2014-06-03 08:51:06 | Memory deallocation after calling cast function |