Re: [PATCH] pgarchives: Fix database install procedure: remove redundant tables in schema.sql

On Fri, Oct 22, 2021 at 5:20 PM Célestin Matte <celestin(dot)matte(at)cmatte(dot)me>
wrote:

> Hello,
>
> Apologies, patch sent in previous email of this thread is incorrect.
> Please find correct patch attached.
>
> In fact, the pgarchives repository is in a weird state, in which the
> migration adding two tables is missing
> (0005_apiclient_threadsubscription.py when running makemigrations). My
> guess is that this is because these tables use SERIALs, which django does
> not handle properly, and must by created using raw SQL. Am I right?
> Is it something that should be fixed?
>

Ugfh, yeah that one is really embarrassing on my part, and I thought I'd
cleaned that one up but clearly not. The whole threadsubscription part
wasn't finished, and was not supposed to be included
in 4d159ca8b4efb0b1cf0893bca63d6e9489a9095f.

The correct solution there is to revert most
of 4d159ca8b4efb0b1cf0893bca63d6e9489a9095f, to have it include only the
parts that are supposed to be there. And then reapply them at some time in
the future when the code is finished. I'll go clean that up -- thanks for
bringing my attention back to that!

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>