Re: pgsql: Allow background workers to bypass datallowconn

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Allow background workers to bypass datallowconn
Date: 2018-04-05 17:14:59
Message-ID: CABUevEwsbsXSvE=p_ZPgzOptaeM3JmSbE730z=ZHi68v6tpL+Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Apr 5, 2018 at 7:11 PM, Teodor Sigaev <teodor(at)sigaev(dot)ru> wrote:

> Something goes wrong
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crak
> e&dt=2018-04-05 17%3A07%3A19
>
> Apr 05 13:09:08 /home/bf/bfr/root/HEAD/pgsql.b
> uild/../pgsql/src/test/modules/worker_spi/worker_spi.c: In function
> ‘worker_spi_main’:
> Apr 05 13:09:08 /home/bf/bfr/root/HEAD/pgsql.b
> uild/../pgsql/src/test/modules/worker_spi/worker_spi.c:182:2: error: too
> few arguments to function ‘BackgroundWorkerInitializeConnection’
> Apr 05 13:09:08 BackgroundWorkerInitializeConnection("postgres", NULL);
> Apr 05 13:09:08 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Apr 05 13:09:08 In file included from /home/bf/bfr/root/HEAD/pgsql.b
> uild/../pgsql/src/test/modules/worker_spi/worker_spi.c:27:0:
> Apr 05 13:09:08 /home/bf/bfr/root/HEAD/pgsql.b
> uild/../pgsql/src/include/postmaster/bgworker.h:143:13: note: declared
> here
> Apr 05 13:09:08 extern void BackgroundWorkerInitializeConnection(const
> char *dbname, const char *username, uint32 flags);
> Apr 05 13:09:08 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Apr 05 13:09:08 <builtin>: recipe for target 'worker_spi.o' failed
>
>
Gah, I didn't run those tests.

Thanks, fix pushed.

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2018-04-05 17:15:00 pgsql: Fix worker_spi for new parameter to initialize connection
Previous Message Teodor Sigaev 2018-04-05 17:11:44 Re: pgsql: Allow background workers to bypass datallowconn