Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: NISHIYAMA Tomoaki <tomoakin(at)staff(dot)kanazawa-u(dot)ac(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64
Date: 2011-12-03 14:20:08
Message-ID: CABUevEwisMTLhPcsgvvxWC+K+eaEKhiBMhn4vyuKAUmThtM3ZQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Dec 3, 2011 at 09:24, NISHIYAMA Tomoaki
<tomoakin(at)staff(dot)kanazawa-u(dot)ac(dot)jp> wrote:
> Hi,
>
> A new patch:
> check for the presence of crtdefs.h in configure
>
> -#if _MSC_VER >= 1400 || defined(WIN64)
> +#if _MSC_VER >= 1400 || HAVE_CRTDEFS_H
>  #define errcode __msvc_errcode
>  #include <crtdefs.h>
>  #undef errcode

Have you verified if tihs affects _MSC_VER < 1400? Suddently that
branch would care about HAVE_CRTDEFS_H, and I'm not sure if that's
something we need to worry about.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message NISHIYAMA Tomoaki 2011-12-03 14:49:47 Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64
Previous Message Dimitri Fontaine 2011-12-03 13:23:48 Re: Command Triggers