Re: pgsql: Prohibit identity columns on typed tables and partitions

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Prohibit identity columns on typed tables and partitions
Date: 2017-12-09 13:47:08
Message-ID: CABUevEwfCEuJ+3ySEU06HzdjrCoQj84h+BsWcV5Fhk0VCXi2Sg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sat, Dec 9, 2017 at 10:45 PM, Peter Eisentraut <
peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:

> On 12/9/17 05:47, Magnus Hagander wrote:
> >
> >
> > On Sat, Dec 9, 2017 at 8:43 AM, Michael Paquier
> > <michael(dot)paquier(at)gmail(dot)com <mailto:michael(dot)paquier(at)gmail(dot)com>> wrote:
> >
> > On Sat, Dec 9, 2017 at 2:26 AM, Peter Eisentraut <peter_e(at)gmx(dot)net
> > <mailto:peter_e(at)gmx(dot)net>> wrote:
> > > Prohibit identity columns on typed tables and partitions
> > >
> > > Those cases currently crash and supporting them is more work then
> > > originally thought, so we'll just prohibit these scenarios for now.
> >
> > + (errcode(ERRCODE_FEATURE_NOT_
> SUPPORTED),
> > + errmsg("identify columns are not
> > supported on partitions")));
> > Er... s/identify/identity/. My fault I guess.
> >
> >
> > Spotted the separate report on it first, so a fix has been pushed.
>
> Please also backpatch to PG10.
>

Oops, I completely missed that the original patch was backpatched. Will
fix, thanks!

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2017-12-09 14:44:08 pgsql: Fix typo
Previous Message Peter Eisentraut 2017-12-09 13:45:36 Re: pgsql: Prohibit identity columns on typed tables and partitions

Browse pgsql-hackers by date

  From Date Subject
Next Message Everaldo Canuto 2017-12-09 13:47:38 Re: proposal: alternative psql commands quit and exit
Previous Message Peter Eisentraut 2017-12-09 13:45:36 Re: pgsql: Prohibit identity columns on typed tables and partitions