Re: Review of VS 2010 support patches

On Thu, Jul 7, 2011 at 02:26, Brar Piening <brar(at)gmx(dot)de> wrote:
> -------- Original Message  --------
> Subject: Re: [HACKERS] Review of VS 2010 support patches
> From: Andrew Dunstan <andrew(at)dunslane(dot)net>
> To: Brar Piening <brar(at)gmx(dot)de>
> Date: 06.07.2011 22:58
>
>>> I'll remove my versions from the patch (v9 probably) if those files get
>>> commited.
>>>
>>
>>
>> I'm just doing some final testing and preparing to commit the new pgflex
>> and pgbison.
>
>
> The attached patch includes documentation changes and excludes my versions
> of pgbison.pl and pgflex.pl which have been replaced by Andrews' versions
> that are already commited.
>
> As before "perltidy_before.patch" has to be applied first and
> "VS2010v9.patch" second.

Something is strange here. Did you run perltidy with the exact
parameters documented in the README file? If so, perltidy seems to be
version- or platform- dependent. I ran it, and got a slightly
different patch. It's not big differences, but the simple fact that
perltidy doesn't always generate the same result is annoying.

Can you run it again, and make sure you get the exact same diff? So
that it wasn't accidentally run off the wrong version or something?

I've attached the differences between your perltidy and my perltidy run.

I'm using (perltidy -v): "This is perltidy, v20090616"

(My plan was to just commit a perltidy run to keep that part out of
the patch for easier handling, but I'd like to figure out this
difference first..)

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/