Re: gitmaster -> anon git repo propagation broken?

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL WWW <pgsql-www(at)postgresql(dot)org>
Subject: Re: gitmaster -> anon git repo propagation broken?
Date: 2016-10-24 13:57:05
Message-ID: CABUevEwUjwbs2Jrmm5pgoiozsS7VONFxW8W2pVhVjAor088TvQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

Mon, Oct 24, 2016 at 3:42 PM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:

> Tom,
>
> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> > Alvaro's recent commits (00f15338b234e5fd et al) appear on gitmaster
> > but not on the anonymous repo, which means they are not getting tested on
> > the buildfarm. This is not good on the day of a release.
>
> There was a failure in the push mechanism but it appears to have cleared
> and the two look current to me now.
>
> I have a feeling we need to review the push script a bit to not update
> the 'last push' timestamp until after we have *successfully* pushed,
> otherwise it gets "stuck" until another commit happens. Not going to
> change that now, given the timing, but will put it on my list of things
> to look at after the release (will plan to chat about it with other
> pginfra folks in Estonia).
>

I think the reasoning behind that is we need to touch it before in case a
new commit shows up while we push it. I guess what we need to do is touch a
tempfile somewhere and the mv it over the actual file if things succeed. We
can probably use the existing lockfile.

But yes, let's shoot holes in that idea in Tallinn.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Browse pgsql-www by date

  From Date Subject
Next Message Tom Lane 2016-10-24 19:48:23 Re: gitmaster -> anon git repo propagation broken?
Previous Message Tom Lane 2016-10-24 13:44:17 Re: gitmaster -> anon git repo propagation broken?