Re: [PATCH pglister] Add Archived-At header to delivered messages

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Denis Laxalde <denis(dot)laxalde(at)dalibo(dot)com>
Cc: PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH pglister] Add Archived-At header to delivered messages
Date: 2021-02-22 12:21:22
Message-ID: CABUevEwUhoNd4r2GXBPVS9q7f=gm30MTeNuhzKwfKSdGacy3LA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

Hi!

Thanks for sending this (though as a reference to next time, it's
easier if you attach the patch rather than paste it).

On Fri, Jan 29, 2021 at 4:38 PM Denis Laxalde <denis(dot)laxalde(at)dalibo(dot)com> wrote:
>
> This changeset adds a new header, Archived-At, to delivered messages.
> This header field contains a direct link to the message in the web
> archive. The Archived-At header is defined by RFC 5064:

This definitely sounds like something we want.

> Notes:
> To build the link, I used the urlpattern field from archive_server table
> and replace '/list/' by '/message-id/':
>
> https://www.postgresql.org/list/% -> https://www.postgresql.org/message-id/
>
> The urlpattern field is now retrieved in 'mailinglists' view, hence the
> migration.
>
> That's not very elegant, but I did not find a better way to achieve this.
> Perhaps adding a 'messageidpattern' column to 'lists_archiveserver' table
> would be better? Or maybe I missed something?

There is already a field called "mailurlpattern" that links to the
individual message. Was there a particular reason you couldn't use
that one, or did you just miss that it existed?

In fact, the commit at
https://gitlab.com/pglister/pglister/-/commit/e8ee5013c096dde0184748b3674a1ae1f0f207c6
created that one specifically to get rid of a previous case that used
the urlpattern and then did substitution that way.

//Magnus

In response to

Responses

Browse pgsql-www by date

  From Date Subject
Next Message Denis Laxalde 2021-02-22 15:54:26 Re: [PATCH pglister] Add Archived-At header to delivered messages
Previous Message Laurenz Albe 2021-02-22 11:52:25 Re: Wiki editor request