Re: pgsql: Fix base backup rate limiting in presence of slow i/o

On Wed, Dec 21, 2016 at 6:55 PM, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
wrote:

> On 19 December 2016 at 09:17, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> > Fix base backup rate limiting in presence of slow i/o
> >
> > Branch
> > ------
> > REL9_4_STABLE
>
> I'm seeing a warning on the 9.4 branch that looks to have been caused
> by this commit:
>
> basebackup.c: In function ‘throttle’:
> basebackup.c:1284:8: warning: variable ‘wait_result’ set but not used
> [-Wunused-but-set-variable]
> int wait_result;
>

Interesting.

ff44fba4 replaced the latch in walsender, which was not backported (of
course).

But it also added a CHECK_FOR_INTERRUPTS there.

9.4 does not have a CHECK_FOR_INTERRUPTS anywhere near there. Perhaps
what's really needed is to put one of those in regardless?

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/