From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Missing newlines in error messages |
Date: | 2016-12-15 15:35:15 |
Message-ID: | CABUevEwE1cR+Kzh+a87mRLNq6UK8-HVun1sQWWiwizVWhn-+5Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
(oops, accidental send button press)
While poking around the pg_basebackup code, I noticed there are a lot of
error messages are missing the \n at the end. Most of them are very
unlikely to happen, but in general I believe all error messages we print to
stderr from those binaries should have a newline at the end.
Is that wrong? :)
Second -- if we were to backpatch something like the attached patch, is
that going to cause issues for translators?
On Thu, Dec 15, 2016 at 4:33 PM, Magnus Hagander <magnus(at)hagander(dot)net>
wrote:
> While poking around the pg_basebackup code, I noticed there are a lot of
> error messa
>
> --
> Magnus Hagander
> Me: http://www.hagander.net/
> Work: http://www.redpill-linpro.com/
>
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
Attachment | Content-Type | Size |
---|---|---|
missing_newlines.patch | text/x-patch | 11.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Wesley Massuda | 2016-12-15 15:38:43 | Proposal : composite type not null constraints |
Previous Message | Magnus Hagander | 2016-12-15 15:33:41 | Missing newlines in error messages |