pg_dump include/exclude fails to error

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Subject: pg_dump include/exclude fails to error
Date: 2024-03-10 14:22:58
Message-ID: CABUevEwC9Q_kmHRC6c5D2PE18FDvqbp_ZZUk88o38WRuJxjzXA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

When including tables with the new pg_dump functionality, it fails to
error out if a table is missing, but only if more than one table is
specified.

E.g., if table foo exist, but not bar:

pg_dump --table bar
pg_dump: error: no matching tables were found

with file "myfilter" containing just "table bar"
pg_dump --filter myfilter
pg_dump: error: no matching tables were found

with the file "myfilter" containing both "table foo" and "table bar"
(order doesn't matter):
<no error, but dump of course only contains foo>

Not having looked into the code, but it looks to me like some variable
isn't properly reset, or perhaps there is a check for existence rather
than count?

//Magnus

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Banck 2024-03-10 14:24:05 Re: [DOC] Add detail regarding resource consumption wrt max_connections
Previous Message Robert Treat 2024-03-10 13:58:25 Re: [DOC] Add detail regarding resource consumption wrt max_connections