Re: Bogus reports from coverage.postgresql.org

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org>
Subject: Re: Bogus reports from coverage.postgresql.org
Date: 2018-03-11 19:56:45
Message-ID: CABUevEwBfBc5n5+AwimrNJG2TxtfnrdR=E7MzATAGZ1EaiR=Dw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

On Sun, Mar 11, 2018 at 8:52 PM, Peter Eisentraut <
peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:

> On 3/11/18 15:24, Tom Lane wrote:
> > So apparently, this bug is specific to gcc 6.3.0 and maybe a few
> > versions on either side of that.
>
> I tried it on Debian stable with gcc 6.3.0 and couldn't reproduce it.
>
> cc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
>
>
Hmm. So it works for you on exactly the same version that the server runs.
That's interesting. Is there something wrong in how we run it? I wonder if
its broken by ccache. What we have is:

# current ccache is useless, because 3.1 doesn't work with -fprofile-arcs.
# Bug is fixed in 3.2, so maybe someday when this is updated to a new debian
# release, this will be useful.
export PATH=/usr/lib/ccache:$PATH

./configure --enable-depend --enable-coverage --enable-tap-tests
--enable-nls --with-python --with-perl --with-tcl --with-openssl
--with-libxml --with-ldap --with-pam >> $LOG 2>&1

# run tests
make -j4 >> $LOG 2>&1
make -j4 -C contrib >> $LOG 2>&1
make check-world >> $LOG 2>&1
make -C src/test/ssl check >> $LOG 2>&1
make -C src/test/ldap check >> $LOG 2>&1

make coverage-html >> $LOG 2>&1

We do now have ccache 3.3.4, so that comment sounds like it's out of date.
But maybe something else broke...

Does that sound likely? We could try to comment out that line and see if it
helps?

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

In response to

Responses

Browse pgsql-www by date

  From Date Subject
Next Message Tom Lane 2018-03-11 20:01:26 Re: Bogus reports from coverage.postgresql.org
Previous Message Peter Eisentraut 2018-03-11 19:52:19 Re: Bogus reports from coverage.postgresql.org