Re: [PATCH] pgweb: Search: bugfix: replace sites.baseurl with sites.hostname

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Célestin Matte <celestin(dot)matte(at)cmatte(dot)me>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
Cc: PostgreSQL WWW <pgsql-www(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] pgweb: Search: bugfix: replace sites.baseurl with sites.hostname
Date: 2021-10-27 13:47:59
Message-ID: CABUevEw6rNMzaZPooV+WPZ9RTn9af9WLqFD-vR_RCYL56HJapQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

On Mon, Oct 25, 2021 at 6:19 PM Célestin Matte <celestin(dot)matte(at)cmatte(dot)me>
wrote:

> Hello,
>
> > But short term, I believe the correct thing to do is to add the baseurl
> field to the table in the SQL file. I'll go push a patch taht does that.
>
> This broke data.sql as baseurl is NOT NULL. Attached patch fixes that.
> This might have also broken the crawler but I haven't installed it to test
> that.
>

Indeed it does. Oops.

That said, most of that file are not-current examples, and should just be
cleaned out, so I'll do that while fixing this.

Yeah, another sign that this needs some proper spring cleaning to get rid
of configuration of the flexibility that we don't care about. But tihs one
for now, to unbreak things short-term.

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

In response to

Browse pgsql-www by date

  From Date Subject
Next Message Magnus Hagander 2021-10-27 13:50:08 Re: [PATCH] pgarchives: Bugfix: allow message's parentid to be null
Previous Message Magnus Hagander 2021-10-27 13:42:00 Re: [PATCH] pgarchives: Allow use of IP ranges for SEARCH_CLIENTS