From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Prevent pg_basebackup -Fp -D -? |
Date: | 2013-10-02 14:31:49 |
Message-ID: | CABUevEw3wdhGqPq=oo9yzr9EOsFL_zzXSn_gk0kJbJx-4UVvGA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Right now, if you use
pg_basebackup -Ft -D -
you get a tarfile, written to stdout, for redirection.
However, if you use:
pg_basebackup -Fp -D -
you get a plaintext (unpackaged) backup, in a directory called "-".
I can't think of a single usecase where this is a good idea. Therefor,
I would suggest we simply throw an error in this case, instead of
creating the directory. Only for the specific case of specifying
exactly "-" as a directory.
Comments?
Also, if we do that, is this something we should consider
backpatchable? It's not strictly speaking a bugfix, but I'd say it
fixes some seriously annoying behavior.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Ants Aasma | 2013-10-02 14:45:07 | Re: [PERFORM] Cpu usage 100% on slave. s_lock problem. |
Previous Message | Oskari Saarenmaa | 2013-10-02 14:23:31 | Re: [PATCH] pg_upgrade: support for btrfs copy-on-write clones |