Re: Blanks in the first line before the first word in the code boxes

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Daniel Westermann <daniel(dot)westermann(at)dbi-services(dot)com>, pgsql-docs <pgsql-docs(at)postgresql(dot)org>
Subject: Re: Blanks in the first line before the first word in the code boxes
Date: 2018-03-29 10:14:45
Message-ID: CABUevEw3sAROjdHW0OE4-i5+uM3VMHQTixtLT+SOWGJapYtaSw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On Thu, Mar 29, 2018 at 4:02 AM, Jonathan S. Katz <jkatz(at)postgresql(dot)org>
wrote:

>
> > On Mar 28, 2018, at 9:47 PM, Peter Eisentraut <
> peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> >
> > On 3/28/18 21:36, Jonathan S. Katz wrote:
> >>
> >>> On Mar 28, 2018, at 9:32 PM, Peter Eisentraut
> >>> <peter(dot)eisentraut(at)2ndquadrant(dot)com
> >>> <mailto:peter(dot)eisentraut(at)2ndquadrant(dot)com>> wrote:
> >>>> Yeah, that looks weird. I'll look into it.
> >>>
> >>> Just looking at a nearby thread ... something is quite whacky with the
> >>> web site stylesheet. It didn't use to look like this. Check this out:
> >>> https://www.postgresql.org/docs/10/static/pgcrypto.html#id-1.11.7.35.5
> >>
> >> Something is adding spaces - it’s within the “<pre>” tag, which causes
> >> browsers
> >> to interpret each space literally.
> >>
> >> For the case of the “digest” function, the outputted HTML shows the
> >> first digest
> >> function indented, the second one at the start of the new line.
> >
> > Yeah, the spaces are in the source, so it's not a CSS issue. But it
> > doesn't come out like that if you build the docs locally. So it's
> > something in the web site code.
>
> If I traced the code correctly, the line I suspect is such:
>
> s = tidy.parseString(contents.encode('utf-8'), **tidyopts)
>
> I know that the web infrastructure recently updated to the Django 1.11
> series, I’m not sure if libtidy or the like were also updated with that.
> I’ll
> defer to Magnus on that.
>

This would not change with the change to Django 1.11 -- the actual script
that loads the docs runs outside of Django.

Now, the entire machine was upgraded to a new Debian meaning new python,
new tidy etc some time ago. But this was done the first week of February.

Is it possible that this issue actually showed up around 4-5 February, but
just has gone unnoticed since?

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Bruce Momjian 2018-03-29 11:55:37 INSTALL.html build error
Previous Message Jonathan S. Katz 2018-03-29 02:02:38 Re: Blanks in the first line before the first word in the code boxes