| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, David Steele <david(at)pgmasters(dot)net>, "wangsh(dot)fnst(at)fujitsu(dot)com" <wangsh(dot)fnst(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: invalid data in file backup_label problem on windows |
| Date: | 2021-03-29 08:34:35 |
| Message-ID: | CABUevEw3aqgdngE9hVF7FT5t4sWgKF27DYWmabEjhEp+s3ymxQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 29, 2021 at 7:01 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Sun, Mar 28, 2021 at 09:29:10AM -0400, Andrew Dunstan wrote:
> > - vital to the backup working, and must be written without modification.
> > + vital to the backup working and must be written without
> > modification, which
> > + may include opening the file in binary mode.
>
> += "on Windows"?
I'd say no, better to just tell people to always open the file in
binary mode. It's not hurtful anywhere, there's really no reason ever
to open it in text mode. And if we clearly tell everybody to open it
in binary mode, that lowers the bar in the unlikely event that we
might want to store some other non-text data in it in the future.
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2021-03-29 08:37:17 | Re: [Proposal] Global temporary tables |
| Previous Message | Andrey Borodin | 2021-03-29 08:26:02 | Re: MultiXact\SLRU buffers configuration |