From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Somewhat excessive version checks |
Date: | 2021-01-12 19:50:40 |
Message-ID: | CABUevEw2Y20sJcQ0r7s6Gi72jsVJaKWitsm3yRkF5Phmfu61pg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Tue, Jan 12, 2021 at 5:59 AM Khushboo Vashi
<khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>
>
> On Tue, Jan 12, 2021 at 3:36 AM Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>>
>> Hi!
>>
>> If I read the code correctly, pgadmin will (unless turned off) hit the
>> website to check the version.json file for updates *every time it
>> starts*.
>>
>> Wouldn't it make sense to rate limit that to checking say once per 24
>> hours maximum? Or even 48?
>>
>> It seems nobody needs the update *that* quickly, and AFAICT it does
>> call out to make that check synchronously on startup which means the
>> user is waiting.
>>
> Agreed, we should have some mechanism in place to limit the server hit, maybe an asynchronous call from the client while loading.
Seems async front he server would be a better choice there, if you
have some ways for that? Otherwise, how to determine which user to
trust when storing the result etc?
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Pradip Parkale | 2021-01-13 03:38:15 | Re: [pgAdmin][RM5912]: Added support for Logical Replication. |
Previous Message | Magnus Hagander | 2021-01-12 19:50:10 | Re: Somewhat excessive version checks |