From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Switch pg_basebackup to use -X stream instead of -X fetch by default? |
Date: | 2014-08-27 06:55:27 |
Message-ID: | CABUevEw-gSHpMdJ0U4wrKK4m+TtmUCOpt3n4w_0_C=mi200NBw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Aug 27, 2014 at 5:16 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Wed, Aug 27, 2014 at 6:16 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> On Tue, Aug 26, 2014 at 10:46 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>>> On 2014-08-26 16:41:44 -0400, Peter Eisentraut wrote:
>>>> On 8/26/14 12:40 PM, Magnus Hagander wrote:
>>>> > I think the first reason is gone now, and the risk/damage of the two
>>>> > connections is probably smaller than running out of WAL. -x is a good
>>>> > default for smaller systems, but -X is a safer one for bigger ones. So
>>>> > I agree that changing the default mode would make sense.
>>>>
>>>> I would seriously consider just removing one of the modes. Having two
>>>> modes is complex enough, and then having different defaults in different
>>>> versions, and fuzzy recommendations like, it's better for "smaller
>>>> systems", it's quite confusing.
>>>
>>> Happy with removing the option and just accepting -X for backward
>>> compat.
>>
>> Works for me - this is really the cleaner way of doing it...
>
> We cannot use -X stream with tar output format mode. So I'm afraid that
> removing -X fetch would make people using tar output format feel disappointed.
> Or we should make -X stream work with tar mode.
Ah, yes, I've actually had that on my TODO for some time.
I think the easy way of doing that is to just create an xlog.tar file.
Since we already create "base.tar" and possibly n*<tablespace.tar>,
adding one more file shouldn't be a big problem, and would make such
an implementation much easier. Would be trivial to do .tar.gz for it
as well, just like for the others.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2014-08-27 07:23:56 | Re: delta relations in AFTER triggers |
Previous Message | Michael Paquier | 2014-08-27 06:53:40 | Re: REINDEX CONCURRENTLY 2.0 |