| From: | Marti Raudsepp <marti(at)juffo(dot)org> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, PG-General Mailing List <pgsql-general(at)postgresql(dot)org> |
| Subject: | Re: pg_test_fsync: "Invalid argument" in the middle of a test |
| Date: | 2014-02-12 20:57:07 |
| Message-ID: | CABRT9RCbGqpzXRjrzpmxf10ULodxNsw9=KFPTieeej8JpOuiWQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general |
On Wed, Feb 12, 2014 at 10:46 PM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Would it be more useful to report the test as failed and continue with
> other tests?
Yeah, I think so, I'm planning to code this in the week. It's harder
than it sounds because the alarm() timer is still ticking. On POSIX it
can be cancelled with alarm(0), but the Windows code spawns a separate
thread for timing.
It seems that TerminateThread [1] could be used on Windows. It has
many caveats, but should be safe for our purposes. Or we could only
implement error handling on POSIX and call exit(1) on Windows.
[1] http://msdn.microsoft.com/en-us/library/windows/desktop/ms686717%28v=vs.85%29.aspx
Regards,
Marti
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2014-02-13 07:30:39 | Re: Xlogdump compiling error : undefined reference to `ber_sockbuf_io_udp' |
| Previous Message | Alvaro Herrera | 2014-02-12 20:46:55 | Re: pg_test_fsync: "Invalid argument" in the middle of a test |