From: | Marti Raudsepp <marti(at)juffo(dot)org> |
---|---|
To: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
Cc: | pgsql-docs <pgsql-docs(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Various documentation typo/grammar fixes |
Date: | 2014-08-25 21:05:09 |
Message-ID: | CABRT9RBDUVXJGoVP3CGL2y5JbpqHSGjH1871wPBj3fw+qX_b3g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs |
On Mon, Aug 25, 2014 at 10:13 PM, Kevin Grittner <kgrittn(at)ymail(dot)com> wrote:
> For the initial patch, I agree with all except the first change of
> "others'" to "other's" -- the start of the sentence uses "All", so
> there is clearly more than one "other", so the the apostrophe
> belongs after the "s".
Not arguing against this, but all the grammar advice I've read
suggests that "each others' " is always wrong. For example
http://jakubmarian.com/each-others-vs-each-others-in-english/
To illustrate this better, supposedly the "other" can be swapped out
for "statement":
All the statements are executed with the same snapshot, so they cannot
see each statements' effects / each statement's effects
What do you think?
> I think most or all of the places that the 0002- patch (i.e. and
> e.g.) need a change to look right, but I'm not sure this goes far
> enough. In style guides I've had to use these generally should
> follow punctuation (left parenthesis, colon, semi-colon, comma, or
> em dash), and be separated from any following text by punctuation
> -- usually a comma.
This matches my research too. I wrote two rules to add commas where no
punctation was being used:
<Typo word="Add comma after i.e. & e.g."
find="\b([Ii]\.e|[Ee]\.g)\.? ?(\s|$)"
replace="$1.,$2" />
<Typo word="Add comma before i.e. & e.g."
find="([a-z])(\s+([Ii]\.e|[Ee]\.g))\b"
replace="$1,$2" />
Attached is the updated 0002 patch. I skimmed over all the differences
and they looked good to me, but with 124 more lines touched, it's
possible that I missed something.
> In patch 0003- I agree that the change to "exactly the same" reads
> better. I'm torn on changing the hyphens to spaces. I probably
> wouldn't change them
Agreed. I'll move the "exactly the same" hunk to patch 0001 once we
settle the "each other" question.
Thanks,
Marti
Attachment | Content-Type | Size |
---|---|---|
0002-doc-Fix-usages-of-etc.-e.g.-i.e.-et-al.patch | binary/octet-stream | 86.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2014-08-25 21:59:58 | Re: [PATCH] Various documentation typo/grammar fixes |
Previous Message | Kevin Grittner | 2014-08-25 19:13:51 | Re: [PATCH] Various documentation typo/grammar fixes |