| From: | Marti Raudsepp <marti(at)juffo(dot)org> |
|---|---|
| To: | Marko Tiikkaja <marko(at)joh(dot)to> |
| Cc: | PG Docs <pgsql-docs(at)postgresql(dot)org> |
| Subject: | Re: Broken example in PL/PgSQL documentation |
| Date: | 2014-10-08 19:25:56 |
| Message-ID: | CABRT9RASN=r8uQt+iC7JRnVo4t0h5XVf9UtvCmhLLxOeZrV0dA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
On Thu, Sep 4, 2014 at 3:06 PM, Marko Tiikkaja <marko(at)joh(dot)to> wrote:
> Just came across a broken example in the docs
+1. New version works. I would slightly prefer adding an alias to the table:
RETURN QUERY SELECT s.quantity, s.quantity * s.price FROM sales AS s
WHERE s.itemno = p_itemno;
Other than that, there's not much to review here, marking as "Ready
for Committer"
Alternative patch attached, let the committer decide.
Regards,
Marti
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-PL-pgSQL-ambiguity-in-RETURNS-TABLE-example.patch | text/x-patch | 914 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2014-10-09 17:37:17 | Re: Broken example in PL/PgSQL documentation |
| Previous Message | Alvaro Herrera | 2014-10-07 17:14:31 | Re: [DOCS] suggestion about SEO on www.postgresql.org/docs |