| From: | Paul Guo <paulguo(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Richard Guo <guofenglinux(at)gmail(dot)com> |
| Subject: | Re: pg_ugprade test failure on data set with column with default value with type bit/varbit |
| Date: | 2018-08-01 03:56:30 |
| Message-ID: | CABQrizfURD9FR-yZ1bTCAZaK=MehOGdYhi7CmXsDdDU13-oLPw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks. I updated the patch as attached.
Double-checked those tests passed.
2018-07-30 9:38 GMT+08:00 Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>:
> On Thu, May 17, 2018 at 8:20 PM, Paul Guo <paulguo(at)gmail(dot)com> wrote:
> > Thanks. I tentatively submitted a patch (See the attachment).
>
> Hi Paul,
>
> It looks like you missed a couple of changes in the contrib/btree_gist
> bit and varbit tests, so make check-world fails:
>
> - Index Cond: ((a >= B'1000000'::"bit") AND (a <= B'1000001'::"bit"))
> + Index Cond: ((a >= '1000000'::"bit") AND (a <= '1000001'::"bit"))
>
> --
> Thomas Munro
> http://www.enterprisedb.com
>
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-pg_upgrade-test-failure-caused-by-the-DDL-below.v2.patch | application/octet-stream | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2018-08-01 04:04:37 | Re: Documentaion fix. |
| Previous Message | Andres Freund | 2018-08-01 03:55:15 | Re: Should contrib modules install .h files? |