Re: pgsql: Modified files for MERGE

From: Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Modified files for MERGE
Date: 2018-04-02 21:56:25
Message-ID: CABOikdPZ+Bi5epprbKCLcvTkWhBLn=pxE7Jou=oxEHzSZmqXkA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Apr 3, 2018 at 2:06 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:

>
> This seems to have turned several animals red:
> - https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=
> thrips&dt=2018-04-02%2020%3A27%3A28
> use of uint, which isn't a portable type.
>

Right.

> - https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=
> calliphoridae&dt=2018-04-02%2020%3A20%3A01
> looks like copy/read/out/equalfuncs aren't properly filled out
>
>
Looks like we missed handling of new MergeAction node in
raw_expression_tree_walker

I will send a add-on patch to fix whatever I could spot before the patch
was reverted. I see Andres has already started discussion about displaying
memory usage which was one other thing I'd spotted while the build farm was
red.

Thanks,
Pavan

--
Pavan Deolasee http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2018-04-03 08:30:37 pgsql: MERGE SQL Command following SQL:2016
Previous Message Peter Geoghegan 2018-04-02 21:55:44 Re: pgsql: Modified files for MERGE