Re: missing LockBuffer(buffer, BUFFER_LOCK_SHARE) in trigger.c GetTupleForTrigger?

From: Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: missing LockBuffer(buffer, BUFFER_LOCK_SHARE) in trigger.c GetTupleForTrigger?
Date: 2012-11-30 13:32:14
Message-ID: CABOikdMr7sWR7FSR-MuJokE3h8eWYM5JvoB42G9+6QAKE7BGxw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 30, 2012 at 6:55 PM, Andres Freund <andres(at)2ndquadrant(dot)com>wrote:

>
>
> Hm? It doesn't move the page contents around but it moves the ItemId
> array during completely normal operation (c.f. needshuffle in
> PageAddItem). Or am I missing something?
>
>
I think that probably only used for non-heap pages. For heap pages, it just
doesn't make sense to shuffle the ItemId array. That would defeat the
entire purpose of having them in the first place.

Thanks,
Pavan

--
Pavan Deolasee
http://www.linkedin.com/in/pavandeolasee

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2012-11-30 13:42:55 Re: Review: Extra Daemons / bgworker
Previous Message Markus Wanner 2012-11-30 13:31:54 Re: Review: Extra Daemons / bgworker