Re: [Patch] remove duplicated smgrclose

Thanks, I have set my name in the Authors column of CF.

Steven

Junwang Zhao <zhjwpku(at)gmail(dot)com> 于2024年8月2日周五 13:22写道：

> Hi Steven,
>
> On Fri, Aug 2, 2024 at 12:12 PM Steven Niu <niushiji(at)gmail(dot)com> wrote:
> >
> > Hi, Junwang,
> >
> > Thank you for the review and excellent summary in commit message!
> >
> > This is my first contribution to community, and not so familiar with the
> overall process.
> > After reading the process again, it looks like that I'm not qualified to
> submit the patch to commitfest as I never had reviewed others' work. :(
> > If so, could you please help to submit it to commitfest?
> >
>
> https://commitfest.postgresql.org/49/5149/
>
> I can not find your profile on commitfest so I left the author as empty,
> have you ever registered? If you have a account, you can put your
> name in the Authors list.
>
> > Best Regards,
> > Steven
> >
> > Junwang Zhao <zhjwpku(at)gmail(dot)com> 于2024年8月1日周四 20:32写道：
> >>
> >> Hi Steven,
> >>
> >> On Wed, Jul 31, 2024 at 11:16 AM Steven Niu <niushiji(at)gmail(dot)com> wrote:
> >> >
> >> > Hello, hackers,
> >> >
> >> > I think there may be some duplicated codes.
> >> > Function smgrDoPendingDeletes() calls both smgrdounlinkall() and
> smgrclose().
> >> > But both functions would close SMgrRelation object, it's dupliacted
> behavior?
> >> >
> >> > So I make this patch. Could someone take a look at it?
> >> >
> >> > Thanks for your help,
> >> > Steven
> >> >
> >> > From Highgo.com
> >> >
> >> >
> >> You change LGTM, but the patch seems not to be applied to HEAD,
> >> I generate the attached v2 using `git format` with some commit message.
> >>
> >> --
> >> Regards
> >> Junwang Zhao
>
>
>
> --
> Regards
> Junwang Zhao
>