Re: Proposal to provide the facility to set binary format output for specific OID's per session

2022年9月6日(火) 21:32 Dave Cramer <davecramer(at)gmail(dot)com>:
>
>
>
>
> On Tue, 6 Sept 2022 at 02:30, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> wrote:
>>
>>
>>
>> On Fri, Aug 12, 2022 at 5:48 PM Dave Cramer <davecramer(at)gmail(dot)com> wrote:
>>>
>>>
>>>
>>> On Fri, 5 Aug 2022 at 17:51, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
>>>>
>>>> On Tue, Jul 26, 2022 at 08:11:04AM -0400, Dave Cramer wrote:
>>>> > Attached patch to correct these deficiencies.
>>>>
>>>> You sent a patch to be applied on top of the first patch, but cfbot doesn't
>>>> know that, so it says the patch doesn't apply.
>>>> http://cfbot.cputube.org/dave-cramer.html
>>>>
>>>> BTW, a previous discussion about this idea is here:
>>>> https://www.postgresql.org/message-id/flat/40cbb35d-774f-23ed-3079-03f938aacdae(at)2ndquadrant(dot)com
>>>
>>>
>>> squashed patch attached
>>>
>>> Dave
>>
>> The patch does not apply successfully; a rebase is required.
>>
>> === applying patch ./0001-add-format_binary.patch
>> patching file src/backend/tcop/postgres.c
>> Hunk #1 succeeded at 97 (offset -8 lines).
>> patching file src/backend/tcop/pquery.c
>> patching file src/backend/utils/init/globals.c
>> patching file src/backend/utils/misc/guc.c
>> Hunk #1 succeeded at 144 (offset 1 line).
>> Hunk #2 succeeded at 244 with fuzz 2 (offset 1 line).
>> Hunk #3 succeeded at 4298 (offset -1 lines).
>> Hunk #4 FAILED at 12906.
>> 1 out of 4 hunks FAILED -- saving rejects to file src/backend/utils/misc/guc.c.rej
>> patching file src/include/miscadmin.h
>>
>
> Thanks,
>
> New rebased patch attached

Hi

cfbot reports the patch no longer applies [1]. As CommitFest 2022-11 is
currently underway, this would be an excellent time to update the patch again.

[1] http://cfbot.cputube.org/patch_40_3777.log

Thanks

Ian Barwick