Re: Review: Patch FORCE_NULL option for copy COPY in CSV mode

From: Ian Lawrence Barwick <barwick(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Payal Singh <payal(at)omniti(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Review: Patch FORCE_NULL option for copy COPY in CSV mode
Date: 2014-01-28 15:28:03
Message-ID: CAB8KJ=gKW-mncg=mFe3h2mR7ji4kMBdJcCqx39UWQ02FnPMATA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2014-01-29 Andrew Dunstan <andrew(at)dunslane(dot)net>:
>
> On 01/28/2014 05:55 AM, Ian Lawrence Barwick wrote:
>>
>>
>> Hi Payal
>>
>> Many thanks for the review, and my apologies for not getting back to
>> you earlier.
>>
>> Updated version of the patch attached with suggested corrections.
>
> On a very quick glance, I see that you have still not made adjustments to
> contrib/file_fdw to accommodate this new option. I don't see why this COPY
> option should be different in that respect.

Hmm, that idea seems to have escaped me completely. I'll get onto it forthwith.

Regards

Ian Barwick

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ioseph Kim 2014-01-28 15:30:14 Mailing subscription test
Previous Message Greg Stark 2014-01-28 15:27:52 Re: proposal: hide application_name from other users