Re: pg_basebackup: add test about zstd compress option

2022年12月5日(月) 23:59 Robert Haas <robertmhaas(at)gmail(dot)com>:
>
> On Fri, Dec 2, 2022 at 11:29 PM Ian Lawrence Barwick <barwick(at)gmail(dot)com> wrote:
> > Though on reflection maybe it's overkill and the existing tests
> > suffice. Anyway leaving the patch here in the interests of pushing
> > this forward in some direction.
>
> Do you think that there is a scenario where 008_untar.pl and
> 009_extract.pl pass but this test fails, alerting us to a problem that
> would otherwise have gone undetected? If so, what is that scenario?
>
> The only thing that I can think of would be if $decompress_program
> --test were failing, but actually trying to decompress succeeded. I
> would be inclined to dismiss that particular scenario as not important
> enough to be worth the additional CPU cycles.

Yeah, it doesn't really add anything, so let's close this one off.

Thanks for the feedback

Ian Barwick