Re: Re: BUG #12885: The result of casting a double to an integer depends on the database version

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pedro Gimeno <pgsql-004(at)personal(dot)formauri(dot)es>, rschaaf(at)commoninf(dot)com, pgsql-bugs(at)postgresql(dot)org
Subject: Re: Re: BUG #12885: The result of casting a double to an integer depends on the database version
Date: 2015-03-25 23:14:12
Message-ID: CAB7nPqTyMLLe228z78Np1Qe0pO-mhSR4tv_M4mFLyhiwGpJt+A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Thu, Mar 26, 2015 at 4:57 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Pedro Gimeno <pgsql-004(at)personal(dot)formauri(dot)es> writes:
>> Tom Lane wrote, On 2015-03-25 18:57:
>>> Hmm ... I'm thinking we probably should explicitly check for inf and NaN,
>>> no?
>
>> I agree about NaN; it worked but mostly by accident. The big number
>> detection catches infinity unambiguously. Added to a comment in the
>> attached (plus corresponding tests).
>
> I fooled around with this some more for clarity and committed it.
> Thanks for your work!

Thanks Tom for wrapping up stuff, and Pedro for the patch.
--
Michael

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message zjwincek 2015-03-25 23:35:41 BUG #12902: The PostgreSQL repository lacks the pg_top package.
Previous Message Duncan Smith 2015-03-25 22:33:38 Wire protocol encoding for 'inet' type is defined unreliably