| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, "yangjie(at)highgo(dot)com" <yangjie(at)highgo(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Anton Dignös <dignoes(at)inf(dot)unibz(dot)it>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Elvis Pranskevichus <elprans(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Jeff Davis <pgsql(at)j-davis(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Mark Rofail <markm(dot)rofail(at)gmail(dot)com>, Martijn van Oosterhout <kleptog(at)svana(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Pierre Ducroquet <p(dot)psql(at)pinaraf(dot)info>, Rafia Sabih <rafia(dot)sabih(at)enterprisedb(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Sokolov Yura <funny(dot)falcon(at)postgrespro(dot)ru>, Tianzhou Chen <tianzhouchen(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Victor Drobny <v(dot)drobny(at)postgrespro(dot)ru>, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
| Subject: | Re: Patches that don't apply or don't compile: 2017-09-12 |
| Date: | 2017-09-12 23:13:08 |
| Message-ID: | CAB7nPqTx=xq9XMqCgf9XEmq_PVEW99n6wjWDHi8aR3nnExyfGQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 13, 2017 at 7:39 AM, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> On 12 Sep 2017, at 23:54, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote:
>> With all due respect, it's hard not to see this as a disruption of the
>> current CF. I agree automating the patch processing is a worthwhile
>> goal, but we're not there yet and it seems somewhat premature.
>>
>> Let me explain why I think so:
>>
>> (1) You just changed the status of 10-15% open patches. I'd expect
>> things like this to be consulted with the CF manager, yet I don't see
>> any comments from Daniel. Considering he's been at the Oslo PUG meetup
>> today, I doubt he was watching hackers very closely.
>
> Correct, I’ve been travelling and running a meetup today so had missed this on
> -hackers.
FWIW, I tend to think that the status of a patch ought to be changed
by either a direct lookup at the patch itself or the author depending
on how the discussion goes on, not an automatic processing. Or at
least have more delay to allow people to object as some patches can be
applied, but do not apply automatically because of naming issues.
There are as well people sending test patches to allow Postgres to
fail on purpose, for example see the replication slot issue not able
to retain a past segment because the beginning of a record was not
tracked correctly on the receiver-side. This can make the recovery
tests fail, but we want them to fail to reproduce easily the wanted
failure.
>> (2) You gave everyone about 4 hours to object, ending 3PM UTC, which
>> excludes about one whole hemisphere where it's either too early or too
>> late for people to respond. I'd say waiting for >24 hours would be more
>> appropriate.
>
> Agreed.
Definitely. Any batch updates have to involve the CFM authorization at
least, in this case Daniel.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2017-09-12 23:14:03 | Re: Other formats in pset like markdown, rst, mediawiki |
| Previous Message | Daniel Gustafsson | 2017-09-12 23:09:51 | Re: [WIP] RE: DECLARE STATEMENT setting up a connection in ECPG |