| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much |
| Date: | 2017-10-25 15:32:52 |
| Message-ID: | CAB7nPqTvM+5A6CTowFt0BNcodV9MSAgGDBJ0igJDmomLPFER1g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Mon, Oct 23, 2017 at 6:50 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> Okay, attached is what I think a fully implemented patch should look
> like. On top of what Andrew has done, I added and reworked the
> following:
> - removed duplicate error handling.
> - documented the function in funcapi.h and funcapi.c.
> - Added a new section in funcapi.h to outline that this is for support
> of VARIADIC inputs.
> I have added a commit message as well. Hope this helps.
For the sake of the archives, the introduction of
extract_variadic_args is committed with f3c6e8a2, and the JSON fixes
with 18fc4ecf. Thanks Andrew for the commit, and thanks Tom, Andrew
and Dmitry for the reviews.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-10-25 19:29:08 | Re: Improper const-evaluation of HAVING with grouping sets and subquery pullup |
| Previous Message | Tom Lane | 2017-10-25 14:34:35 | Re: Segfault 11 on PG10 with max_parallel_workers_per_gather>3 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-10-25 15:41:09 | Re: CurTransactionContext freed before transaction COMMIT ??? |
| Previous Message | Gaddam Sai Ram | 2017-10-25 14:34:30 | Re: CurTransactionContext freed before transaction COMMIT ??? |