Re: pgsql: Convert psql's flex lexer to be re-entrant, and make it compile

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Convert psql's flex lexer to be re-entrant, and make it compile
Date: 2016-03-19 01:43:32
Message-ID: CAB7nPqTttcpBoh23CctjZ9SjE0SnT2xOoSAuYYzwRt=QY3jahQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sat, Mar 19, 2016 at 10:22 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Also, stop compiling psqlscan as part of mainloop.c, and make it a
> standalone build target instead. This is a lot cleaner than before, though
> it doesn't really change much in practice as of this commit. (I'm not sure
> whether the MSVC build scripts will need some help with this part, but the
> buildfarm will soon tell us.)

This is fine, no tweaking is needed. psql is listing directly
psqlscan.l as a file, and .c from generated from .l files with flex
are generated unconditionally before the compilation.
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-03-19 04:25:07 pgsql: Split psql's lexer into two separate .l files for SQL and backsl
Previous Message Tom Lane 2016-03-19 01:22:19 pgsql: Convert psql's flex lexer to be re-entrant, and make it compile