Re: Declarative partitioning

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Declarative partitioning
Date: 2015-08-20 07:05:17
Message-ID: CAB7nPqTtN=Xy5iGVtbyt8OX6+-T3rNc-r8MfEDdvOStFVveGyA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 20, 2015 at 11:16 AM, Amit Langote <
Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:

> On 2015-08-19 PM 09:23, Simon Riggs wrote:
> > We'll need regression tests that cover each restriction and docs that
> > match. This is not something we should leave until last. People read the
> > docs to understand the feature, helping them to reach consensus. So it is
> > for you to provide the docs before, not wait until later. I will begin a
> > code review once you tell me docs and tests are present. We all want the
> > feature, so its all about the details now.
> >
>
> Sorry, should have added tests and docs already. I will add them in the
> next version of the patch.
>

Yes, those would be really good to have before any review so as it is
possible to grasp an understanding of what this patch does. I would like to
look at it as well more in depths.

> Thanks for willing to review.
>

Really thanks for working on that! I am sure you are going to get a lot of
feedback.
Regards,
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2015-08-20 07:19:10 Re: proposal: function parse_ident
Previous Message Michael Paquier 2015-08-20 06:57:20 Re: Use pg_rewind when target timeline was switched