| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Jim Nasby <jim(at)nasby(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Review of Refactoring code for sync node detection |
| Date: | 2014-11-18 21:23:15 |
| Message-ID: | CAB7nPqTpTeQxLcHHyA5_2_goC4e=WE1RVy_ABRgyoZg36wKUsQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 18, 2014 at 6:33 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> Can we just wait on this patch until we have the whole feature?
>
Well, this may take some time to even define, and even if goals are clearly
defined this may take even more time to have a prototype to discuss about.
> We quite often break larger patches down into smaller ones, but if
> they arrive in lots of small pieces its more difficult to understand
> and correct issues that are happening on the larger scale. Churning
> the same piece of code multiple times is rather mind numbing.
>
Hm. I think that we are losing ourselves in this thread. The primary goal
is to remove a code duplication between syncrep.c and walsender,c that
exists since 9.1. Would it be possible to focus only on that for now?
That's still the topic of this CF.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2014-11-18 21:28:17 | Re: proposal: plpgsql - Assert statement |
| Previous Message | Petr Jelinek | 2014-11-18 21:19:40 | Re: proposal: plpgsql - Assert statement |