Re: Build broken with nmake since ea74e47

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: PostgreSQL mailing lists <pgsql-odbc(at)postgresql(dot)org>
Subject: Re: Build broken with nmake since ea74e47
Date: 2016-07-01 04:27:21
Message-ID: CAB7nPqToU=-9qhhYpnHW+G74rN35Ct7DpUP8-un5HEvgzh=TmQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-odbc

On Thu, Jun 30, 2016 at 12:45 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> Hi,
>
> Since commit ea74e47, the build with nmake is broken:
> NMAKE : fatal error U1073: don't know how to make 'exe\connect-test.exe'
> I have yet to diagnose what is wrong here, but a guess is that win.mak
> is missing a trick.

After spending some time on that, I can reproduce the problem, but I
have little idea how to properly link each exe and src file with
common.obj at the same time using this nmake Makefile. ea74e47 has
really introduced a broken concept in win.mak, and I am sure that this
has not been tested. Could it be possible to get back to the prior
behavior for just nmake? For example the patch attached does the job
for me again.

At the same time, I have noticed a compilation error in
large-object-data-at-exec-test.c regarding a type declaration in the
middle of a code block, basically that:
- int error = SQL_SUCCESS != rc && SQL_SUCCESS_WITH_INFO != rc
&& SQL_NEED_DATA != rc;
+ error = SQL_SUCCESS != rc &&
+ SQL_SUCCESS_WITH_INFO != rc &&
+ SQL_NEED_DATA != rc;
--
Michael

Attachment Content-Type Size
pgodbc-nmake-fix.patch text/x-diff 1.6 KB

In response to

Responses

Browse pgsql-odbc by date

  From Date Subject
Next Message Tsunakawa, Takayuki 2016-07-01 05:38:04 Re: PostgreSQL: SQLSetPos fails with SetPos update return error.
Previous Message Michael Paquier 2016-06-30 07:45:05 Build broken with nmake since ea74e47