Re: Small fix in pg_rewind (redundant declaration)

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: YUriy Zhuravlev <u(dot)zhuravlev(at)postgrespro(dot)ru>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small fix in pg_rewind (redundant declaration)
Date: 2015-12-18 01:07:55
Message-ID: CAB7nPqTmz-ybU1pVUvGTxtgcR-we_FYryfq4dMpUk3+ktd4CJg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 17, 2015 at 9:23 PM, YUriy Zhuravlev
<u(dot)zhuravlev(at)postgrespro(dot)ru> wrote:
> Hello hackers.
> I've stumbled upon a strange code.
> In src/bin/pg_rewind/datapagemap.h we decalre:
> extern void datapagemap_destroy(datapagemap_t *map);
> But nowhere is implemented. I think the declaration of this function must be
> removed.
> I'm not sure that this trivial things needed patch.

Nicely noticed. That's a bug present as well in the 9.3 and 9.4
versions of pg_rewind (just fixed it there). datapagemap_create can be
additionally removed.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-12-18 01:22:26 Re: Small fix in pg_rewind (redundant declaration)
Previous Message Michael Paquier 2015-12-18 00:09:10 Re: extend pgbench expressions with functions