| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Asif Naeem <anaeem(dot)it(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andreas Karlsson <andreas(at)proxel(dot)se>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgcrypto compilation error due to stack-allocated EVP_CIPHER_CTX |
| Date: | 2016-12-12 05:18:09 |
| Message-ID: | CAB7nPqTmLAjA7k8D-TNXE-5LgtP6gPzBfz8TTwyvOdmGEd-nsg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 9, 2016 at 10:22 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> Thanks for looking at the patch. Looking forward to hearing more!
Here is an updated patch based on which reviews should be done. I have
fixed the issue you have reported, and upon additional lookup I have
noticed that returning -1 when failing on EVP_CIPHER_CTX_new() in
px_find_cipher() is dead wrong. The error code should be
PXE_CIPHER_INIT.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| pgcrypto-openssl11-fix-v4.patch | invalid/octet-stream | 6.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2016-12-12 06:20:19 | Re: proposal: psql statements \gstore \gstore_binary (instead COPY RAW) |
| Previous Message | Amit Langote | 2016-12-12 05:06:45 | Re: [COMMITTERS] pgsql: Implement table partitioning. |