| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: Multiple false-positive warnings from Valgrind |
| Date: | 2017-04-01 14:19:05 |
| Message-ID: | CAB7nPqTgzjmLyAHZe1HGKXti0hs9E7w-0SFFf0d9v9w0PMW72A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Apr 1, 2017 at 2:51 PM, Noah Misch <noah(at)leadboat(dot)com> wrote:
> Does this remove the noise under --with-openssl?
>
> --- a/src/port/pg_strong_random.c
> +++ b/src/port/pg_strong_random.c
> @@ -104,7 +104,10 @@ pg_strong_random(void *buf, size_t len)
> */
> #if defined(USE_OPENSSL_RANDOM)
> if (RAND_bytes(buf, len) == 1)
> + {
> + VALGRIND_MAKE_MEM_DEFINED(buf, len);
> return true;
> + }
> return false;
>
> /*
Actually, no. I'll dig more into the options of valgrind to see if I
am missing something here..
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-04-01 14:28:23 | Re: [COMMITTERS] pgsql: Avoid GatherMerge crash when there are no workers. |
| Previous Message | anant khandelwal | 2017-04-01 14:03:57 | GSoC 2017 Proposal for "Explicitly support predicate locks in index access methods besides btree" |