| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Дмитрий Воронин <carriingfate92(at)yandex(dot)ru>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: New functions |
| Date: | 2015-09-08 13:17:46 |
| Message-ID: | CAB7nPqTgA+X-_vRE8VJh0KLxBYun5Yx-5+3iukaYXcpYPHfT9Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 8, 2015 at 9:32 AM, Alvaro Herrera wrote:
> Michael Paquier wrote:
> I made a couple extra cleanups to the patch, namely: do not call
> CreateTemplateTupleDesc() just to discard the resulting tupdesc with a
> subsequent get_call_result_type(); and do not write a \0 to the
> BIO_s_mem, and instead use BIO_get_mem_data's return value as length
> when converting str to text *.
Thanks!
> FWIW I now think I made a mistake with the error checks that I
> backpatched, because the wording of the error messages I used "failed to
> foo" is frowned upon by our message style guidelines. Should be "could
> not do foo" instead.
Well... Feel free to use that if it makes you gain two minutes.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20150908_sslinfo_messages.patch | binary/octet-stream | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2015-09-08 13:29:12 | Re: Proposal: Implement failover on libpq connect level. |
| Previous Message | Pavel Stehule | 2015-09-08 12:57:19 | Re: proposal: function parse_ident |