Re: Additional role attributes && superuser review

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Gavin Flower <GavinFlower(at)archidevsys(dot)co(dot)nz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Additional role attributes && superuser review
Date: 2015-08-25 13:08:38
Message-ID: CAB7nPqTg7BAe2YAyfAPqNSFr7fXkvu-ovQ7g-aKEHxntuEVuZA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jul 11, 2015 at 6:06 AM, Heikki Linnakangas wrote:
> On 05/08/2015 07:35 AM, Stephen Frost wrote:
>> In consideration of the fact that you can't create schemas which start
>> with "pg_" and therefore the default search_path wouldn't work for that
>> user, and that we also reserve "pg_" for tablespaces, I'm not inclined
>> to worry too much about this case. Further, if we accept this argument,
>> then we simply can't ever provide additional default or system roles,
>> ever. That'd be a pretty narrow corner to have painted ourselves into.
>
>
> Well, you could still provide them through some other mechanism, like
> require typing "SYSTEM ROLE pg_backup" any time you mean that magic role.
> But I agree, reserving pg_* is much better. I wish we had done it when we
> invented roles (6.5?), so there would be no risk that you would upgrade from
> a system that already has a "pg_foo" role. But I think it'd still be OK.
>
> I agree with Robert's earlier point that this needs to be split into
> multiple patches, which can then be reviewed and discussed separately.
> Pending that, I'm going to mark this as "Waiting on author" in the
> commitfest.

... And now marked as returned with feedback.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2015-08-25 13:40:01 Re: Commitfest remaining "Needs Review" items
Previous Message Michael Paquier 2015-08-25 13:05:05 Re: compress method for spgist - 2