From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: WAL-related tools and .paritial WAL file |
Date: | 2015-07-01 07:04:02 |
Message-ID: | CAB7nPqTZYZQQSiLcjqHRQCVVLn032yhwrtSiegQs_4v_NF1Jig@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jul 1, 2015 at 2:52 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Wed, Jul 1, 2015 at 9:09 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>
>> Also regarding pg_xlogdump, we can just document, for example,
>> "please get rid of .paritial suffix from the WAL file name if
>> you want to dump it by pg_xlogdump".
>>
>
> Can't we skip such files in pg_xlogdump?
.partial files are at the end of a timeline, so they will be ignored
now (and this even if a node on the old timeline archives the same
segment as the .partial one sent by the promoted standby). And as
pg_xlogdump is not able to follow a timeline jump there is nothing we
would need to do:
$ pg_xlogdump 000000010000000000000006 000000020000000000000008
pg_xlogdump: FATAL: could not find file "000000020000000000000006":
No such file or directory
$ pg_xlogdump -t 1 000000010000000000000006 000000020000000000000008
pg_xlogdump: FATAL: could not find file "000000020000000000000006":
No such file or directory
I am not convinced that it is worth to make pg_xlogdump follow
timeline jumps as well.. One could just run it twice on the old and
new timeline segments to get the output he wants.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2015-07-01 07:22:33 | Re: Solaris testers wanted for strxfrm() behavior |
Previous Message | Michael Paquier | 2015-07-01 06:52:05 | Re: WAL-related tools and .paritial WAL file |