Re: Regression tests failing if not launched on db "regression"

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Christian Kruse <christian(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Regression tests failing if not launched on db "regression"
Date: 2014-01-31 07:28:49
Message-ID: CAB7nPqTXcxHD=t+viRnVP05NifEr2dbrJc-4KC1uh7RcftCWGQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 31, 2014 at 6:09 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Jan 30, 2014 at 3:32 AM, Christian Kruse
> <christian(at)2ndquadrant(dot)com> wrote:
>>> For the documentation patch, I propose the attached to avoid future
>>> confusions. Comments? It might make sense to back-patch as well.
>>
>> Compiles, didn't find any typos and I think it is comprehensible.
>
> I took a look at this with a view to committing it but on examination
> I'm not sure this is the best way to proceed. The proposed text
> documents that the tests should be run in a database called
> regression, but the larger documentation chapter of which this section
> is a part never explains how to run them anywhere else, so it feels a
> bit like telling a ten-year-old not to burn out the clutch.
>
> The bit about not changing enable_* probably belongs, if anywhere, in
> section 30.2, on test evaluation, rather than here.
And what about the attached? I have moved all the content to 30.2, and
added two paragraphs: one about the planner flags, the other about the
database used.
Regards,
--
Michael

Attachment Content-Type Size
20140131_doc_regress_restriction_v2.patch text/x-diff 1.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2014-01-31 08:05:19 Re: Retain dynamic shared memory segments for postmaster lifetime
Previous Message Peter Geoghegan 2014-01-31 06:51:07 Re: Prefix compression of B-Tree keys