| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Payal Singh <payal(at)omniti(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Review: Patch FORCE_NULL option for copy COPY in CSV mode |
| Date: | 2014-03-03 11:48:53 |
| Message-ID: | CAB7nPqTSyJisq4ba2i-iErwVk+2RGe62YBqK5KnF9WkQHEfj-A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 3, 2014 at 1:13 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>> That difference actually made the file_fdw regression results plain
>>> wrong,
>>> in my view, in that they expected a quoted empty string to be turned to
>>> null
>>> even when the null string was something else.
>>>
>>> I've adjusted this and the docs and propose to apply the attached patch
>>> in
>>> the next day or two unless there are any objections.
>>
>> Unless I'm overlooking something, output from "SELECT * FROM text_csv;"
>> in 'output/file_fdw.source' still needs updating?
While reading this patch, I found a small typo in copy2.[sql|out] =>
s/violiaton/violation/g
Regards,
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-03-03 11:57:00 | Re: heapgetpage() and ->takenDuringRecovery |
| Previous Message | KONDO Mitsumasa | 2014-03-03 10:50:41 | Re: gaussian distribution pgbench |