Re: pg_dump gets attributes from tables in extensions

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump gets attributes from tables in extensions
Date: 2015-02-25 01:48:12
Message-ID: CAB7nPqTStdWB_p7sxwLBGwPvHzsvfwysN4PTCw9LFjA_mxEyxQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 25, 2015 at 10:30 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
wrote:

> Michael Paquier wrote:
> > On Tue, Feb 24, 2015 at 11:55 PM, Alvaro Herrera <
> alvherre(at)2ndquadrant(dot)com>
> > wrote:
>
> > > Maybe something in src/test/modules could keep these files so that
> > > pg_dump can be tested. Is anybody interested in doing that?
> >
> > For the patch to fix data dump of extensions that contain tables with FK
> I
> > have implemented a test case in src/test/modules as I didn't want to look
> > at postgis stuff to reproduce the failure, last version is here:
> >
> http://www.postgresql.org/message-id/CAB7nPqQRjHHmNMcGB0eCVZ2PTMNCmFD+1htLOoxRQjMzgtSetQ@mail.gmail.com
>
> That looks interesting -- I don't recall seeing it. Does it support
> more doing than one extension? If so, we could certainly integrate it.
>

It uses TAP tests to kick pg_dump commands, and I haven't added any logic
for having more than one extension installed within a single test if that
is what you mean, but I assume that we could pass to prove_check a variable
able to install multiple paths and install their content. For now though
what I have done is adding one line to prove_check to install the content
of current directory to be able to run TAP tests with one extension.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2015-02-25 03:25:59 Re: pg_dump gets attributes from tables in extensions
Previous Message Amit Langote 2015-02-25 01:33:47 Re: Partitioning WIP patch (was: Partitioning: issues/ideas)