| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Add WaitForLockers in lmgr, refactoring index.c code |
| Date: | 2013-10-02 02:31:13 |
| Message-ID: | CAB7nPqTSWD3oR3gJx+3pchkKDWfCB+yFM+EAxJKufvubOykQeg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, Oct 2, 2013 at 6:32 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> Andres Freund wrote:
>> I think this removes too many comments from index_drop that explains why
>> it's done that way.
>
> Complaint registered. If either of you can send a patch I will gladly
> push it, otherwise it will take me some time to get back to it (but will
> eventually).
Indeed, it might be better to add some more comments. Attached is a
patch improving that.
Regards,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20131002_index_drop_comments.patch | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2013-10-02 14:46:19 | pgsql: Fix copy/paste error |
| Previous Message | Bruce Momjian | 2013-10-01 23:45:39 | pgsql: Adjust C comments that would be wrap-able. |